pkg/asset/installconfig/ssh: Discover ~/.ssh/*.pub #199
Conversation
openshift-ci-robot
added
size/L
wking
force-pushed
the
ssh-prompts
branch
2 times, most recently
from
fd574cf to
b7bce87
Compare
The test suite imports the TLS asset package, but keeping that import out of the validate package itself allows us to import the validate package from pkg/asset and descendants without having to worry about cyclic imports. I've moved the lastIP test into a separate file (which stays in the validate package) so I can test the helper without making it part of the public API. The BUILD.bazel change was generated with: $ bazel run //:gazelle
With this commit, we get a new prompt like: SSH Public Key: Enter an empty string, your public key (e.g. 'ssh-rsa AAAA...'), or one of the following numbers: 1: /home/trking/.ssh/id_rsa.pub This commit also adds an "is this SSH pubkey valid?" check based on our previous validation. The BUILD.bazel change was generated with: $ bazel run //:gazelle The testify addition there is catching up with 345d843 (asset: Only persistent data to disk for targetable assets, 2018-08-30, openshift#196).
|
A unit test to test the input reading would be nice :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking, yifan-gu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
I'm not very clear on what's going on with these CI failure. The ShellCheck and YAML lint jobs are reporting an error in the GitHub UI here, but have no
but that job has no artifacts outside of |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 participants
With this commit, we get a new prompt like:
This commit also adds an "is this SSH pubkey valid?" check based on our previous validation.
CC @yifan-gu.